Skip to content

Conversation

@CybotTM
Copy link
Contributor

@CybotTM CybotTM commented Dec 6, 2025

Recreated from PR #397

This PR is a recreation of #397 after the source fork was accidentally deleted.


Problem

The current documentation doesn't clearly state that Resolves: is REQUIRED for all commits. Contributors sometimes use only Related: which causes the commit-msg hook to reject their commits with:

You need at least one 'Resolves|Fixes: #<issue number>' line

This confusion was discovered during real-world TYPO3 Core contribution workflow.

Changes

This PR makes the requirement explicit within the existing documentation structure:

  • Mark Resolves: section with (REQUIRED) label
  • Change "You need to" to "You must" for clarity
  • Add one sentence explaining the commit-msg hook rejects commits without Resolves:
  • Mark Related: section with (OPTIONAL) label
  • Clarify that Related: cannot be used alone - at least one Resolves: line is needed

Impact

Contributors will clearly understand:

  • Resolves: is mandatory (not optional)
  • Related: is supplementary (cannot stand alone)
  • Why their commits get rejected if they only use Related:

This prevents wasted time debugging commit rejections.


Previous review status on #397:

CybotTM and others added 2 commits October 28, 2025 09:06
Make it explicit that 'Resolves:' is required and 'Related:' is
optional. The commit-msg hook rejects commits without at least one
'Resolves:' line, but this was not clearly stated in the documentation.

Changes:
* Mark 'Resolves:' as (REQUIRED) and clarify it is mandatory
* Add note that commit-msg hook rejects commits without Resolves
* Mark 'Related:' as (OPTIONAL) and clarify it cannot be used alone
* Emphasize that at least one 'Resolves:' line is needed

This addresses confusion where contributors used only 'Related:' and
had their commits rejected.
Releases: main
@linawolf linawolf merged commit 45c9307 into TYPO3-Documentation:main Dec 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants