(fix):not have encoder_only attr cause run failed#1741
Open
wangyufak wants to merge 1 commit intoTHUDM:mainfrom
Open
(fix):not have encoder_only attr cause run failed#1741wangyufak wants to merge 1 commit intoTHUDM:mainfrom
wangyufak wants to merge 1 commit intoTHUDM:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(fix):not have encoder_only attr cause run failed
sglang_engine has server_args, if worker_type is regular, server_args will not have encoder_only attr, then will happen a bug.
File "/code/slime/backends/sglang_utils/sglang_engine.py", line 164, in init
self._init_normal(server_args_dict)
File "/code/slime/backends/sglang_utils/sglang_engine.py", line 192, in _init_normal
self.process = launch_server_process(ServerArgs(**server_args_dict))
File "/code/slime/backends/sglang_utils/sglang_engine.py", line 54, in launch_server_process
if server_args.encoder_only:
AttributeError: 'ServerArgs' object has no attribute 'encoder_only