Fix: Apply loss mask to KL in REINFORCE++ returns calculation #1372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1370 - Apply loss mask to KL divergence before computing returns in get_reinforce_plus_plus_returns.
Problem
In REINFORCE++ advantage estimation, the KL divergence values were not masked before computing returns. This caused environment-generated tokens (e.g., tool_response in agentic RL scenarios) to incorrectly contribute to the KL penalty that propagates through the cumulative return calculation.
Solution
Apply loss_mask to zero out KL values at masked positions before computing returns: