Skip to content

Add accessibility configuration to happo.config.js#2987

Draft
samuelwei wants to merge 1 commit intodevelopfrom
add-happo-accessibility
Draft

Add accessibility configuration to happo.config.js#2987
samuelwei wants to merge 1 commit intodevelopfrom
add-happo-accessibility

Conversation

@samuelwei
Copy link
Copy Markdown
Collaborator

Fixes #

Type

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

Other information

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c0556849-8428-40dc-8a51-7373923b55db

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-happo-accessibility

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.70%. Comparing base (e42af64) to head (8053266).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2987      +/-   ##
=============================================
+ Coverage      96.27%   96.70%   +0.43%     
  Complexity      1906     1906              
=============================================
  Files            266      445     +179     
  Lines           6570    12878    +6308     
  Branches           0     2072    +2072     
=============================================
+ Hits            6325    12454    +6129     
- Misses           245      424     +179     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cypress
Copy link
Copy Markdown

cypress bot commented Mar 26, 2026

PILOS    Run #2886

Run Properties:  status check failed Failed #2886  •  git commit 8053266620: Add accessibility configuration to happo.config.js
Project PILOS
Branch Review add-happo-accessibility
Run status status check failed Failed #2886
Run duration 07m 23s
Commit git commit 8053266620: Add accessibility configuration to happo.config.js
Committer Samuel Weirich
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 619
View all changes introduced in this branch ↗︎

Tests for review

Failed  e2e/RoomsJoinWithLobby.cy.js • 2 failed tests • System tests

View Output

Test Artifacts
Room Join with lobby settings > Lobby enabled Test Replay Screenshots
Room Join with lobby settings > Lobby enabled for guests only Test Replay Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant