Add close button to room share popover (screen readers only)

[samuelwei]

Fixes #

Type

• Bugfix
• Feature
• Documentation
• Refactoring (e.g. Style updates, Test implementation, etc.)
• Other (please describe):

Checklist

• Code updated to current develop branch head
• Passes CI checks
• Is a part of an issue
• Tests added for the bugfix or newly implemented feature, describe below why if not
• Changelog is updated
• Documentation of code and features exists

Changes

Other information

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 16f805dd-dd8d-47d2-b8c3-26dea1a0888b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch a11y-add-sr-only-close-button

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.68%. Comparing base (de491e3) to head (98a56d3).

Files with missing lines	Patch %	Lines
resources/js/components/RoomShareButton.vue	40.00%	3 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #2971      +/-   ##
=============================================
- Coverage      96.71%   96.68%   -0.04%     
  Complexity      1907     1907              
=============================================
  Files            445      445              
  Lines          12886    12889       +3     
  Branches        2075     2075              
=============================================
- Hits           12463    12462       -1     
- Misses           423      427       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[cypress]

PILOS    Run #2893

Run Properties:   Failed #2893  •  98a56d379e: Add close button to room share popover (screen readers only)

Project	PILOS
Branch Review	a11y-add-sr-only-close-button
Run status	Failed #2893
Run duration	07m 15s
Commit	98a56d379e: Add close button to room share popover (screen readers only)
Committer	Samuel Weirich
View all properties for this run ↗︎

---

Test results
Failures	1
Flaky	0
Pending	0
Skipped	0
Passing	621
View all changes introduced in this branch ↗︎

---

Tests for review

  e2e/RoomsJoinWithLobby.cy.js • 1 failed test • System tests

View Output

Test		Artifacts
Room Join with lobby settings > Lobby enabled for guests only		Test Replay Screenshots