Skip to content

Conversation

@suwilsoncongruex
Copy link

@suwilsoncongruex suwilsoncongruex commented Nov 21, 2025

Remove requirements-test.txt, and just install all the dependencies using the toml file. That way we won't have to maintain two parallel sets of dependencies.

We are not running any actions on PRs or merges, so I'm not quite sure how to validate this, except that it works when I run it locally!

Copy link

@pickgr pickgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want us to create a 1.4.1.post2 tag (release) after this is merged?

@suwilsoncongruex
Copy link
Author

suwilsoncongruex commented Nov 21, 2025

Do you want us to create a 1.4.1.post2 tag (release) after this is merged?

I don't think we necessarily need a new tag, since it just affects running the tests, but we should test it somehow...

@pickgr
Copy link

pickgr commented Nov 21, 2025

Do you want us to create a 1.4.1.post2 tag (release) after this is merged?

I don't think we necessarily need a new tag, since it just affects running the tests, but we should test it somehow...

You could temporarily hack the workflow on this branch if so it will trigger with this PR if you think that's necessary. Make sure the steps to publish to pypi are commented out.

@suwilsoncongruex
Copy link
Author

@kjonick If you have a few minutes could you please see if you can test this change to make sure I didn't break anything?

@pickgr
Copy link

pickgr commented Nov 21, 2025

@kjonick If you have a few minutes could you please see if you can test this change to make sure I didn't break anything?

@suwilsoncongruex you can pull #9 into your branch and test that way or we can merge #9 to main and then pull it in.

@pickgr
Copy link

pickgr commented Nov 21, 2025

Verified that tests still work. See https://github.com/TES-Software/docxcompose/actions/runs/19586752390/job/56097130756?pr=8

image

@pickgr pickgr merged commit 2fd8e87 into main Nov 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants