-
Notifications
You must be signed in to change notification settings - Fork 0
Fix/#157 디테일잡자 #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/#157 디테일잡자 #158
The head ref may contain hidden characters: "fix/#157-\uB514\uD14C\uC77C\uC7A1\uC790"
Conversation
📝 WalkthroughWalkthrough이 변경사항은 Xcode 프로젝트의 앱 방향 설정을 단순화하고, 여러 SwiftUI 뷰에 일관된 상단 여백(20.adjustedH)을 추가합니다. 기능적 로직 변경 없이 UI 레이아웃 조정만 포함합니다. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 분 Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Cherrish-iOS/Cherrish-iOS/Presentation/Feature/Calendar/SelectTreatment/SelectTreatmentView.swift (1)
15-29: body 내 Spacer가 VStack으로 감싸지지 않아 다른 뷰들과 레이아웃 동작이 다를 수 있습니다.다른 뷰들(NoTreatmentView, TreatmentView, CreateChallengeView)은
VStack(spacing: 0)으로 전체를 감싸고 그 안에 Spacer를 배치했지만, 이 뷰는 Spacer가 body에 직접 배치되어 있습니다. 이로 인해 부모 컨테이너에 따라 레이아웃 동작이 달라질 수 있습니다.🔧 일관성을 위한 수정 제안
var body: some View { + VStack(spacing: 0) { Spacer() .frame(height: 20.adjustedH) CherrishNavigationBar( title: "시술 여부 선택", leftButtonAction: { calendarCoordinator.pop() tabBarCoordinator.isTabbarHidden = false }, rightButtonAction: { tabBarCoordinator.isTabbarHidden = false calendarCoordinator.popToRoot() } ) VStack(spacing: 0) { // ... existing content } + } }
wotjs020708
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어푸푸
soseoyo12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다
sum130
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋습니당 굿굿뜨!!!
🔗 연결된 이슈
📄 작업 내용