Skip to content

Enable logging#1

Closed
Morilli wants to merge 1 commit intoTASEmulators:wbxfrom
Morilli:enable-logging
Closed

Enable logging#1
Morilli wants to merge 1 commit intoTASEmulators:wbxfrom
Morilli:enable-logging

Conversation

@Morilli
Copy link
Copy Markdown

@Morilli Morilli commented Oct 8, 2025

It's impossible to see error messages in this function because it force-disables logging output for some reason.

@vadosnaprimer
Copy link
Copy Markdown

vadosnaprimer commented Mar 12, 2026

Oh I wasn't subscribed to the repo and missed this PR. It still applies, right?

Asking because e917f87

@Morilli
Copy link
Copy Markdown
Author

Morilli commented Mar 12, 2026

Not required anymore since errors now generate a message box, this would just enable console logging (the lprintf calls in the core) in places where it wouldn't do that before.

@vadosnaprimer
Copy link
Copy Markdown

@Morilli
Copy link
Copy Markdown
Author

Morilli commented Mar 12, 2026

But we already have https://github.com/TASEmulators/BizHawk/blob/97764d174889ffeb1db6bbb05bd81e24ac57a609/waterbox/dsda/BizhawkInterface.c#L510

Right, I think this needs to be moved earlier as well to catch prints in the headlessMain function. Currently doing that would immediately disable enableOutput again because of the enableOutput = 0 in d_main, so we need to both remove the line setting enableOutput to 0 and move the line setting it to 1 earlier in BizHawkInterface.

It's been a while since I made this PR so I forgot that part.

vadosnaprimer added a commit that referenced this pull request Mar 14, 2026
resolves #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants