Skip to content

more sensible handling of our special hotkey default binding "conflicts" #4584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SuuperW wants to merge 1 commit into
base: master
Choose a base branch
from
Open

more sensible handling of our special hotkey default binding "conflicts" #4584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/BizHawk.Client.Common/config/Binding.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,8 @@ void Bind(string tabGroup, string displayName, string defaultBinding = "", strin

#if DEBUG
var bindings = dict.Values
.Where(static info => !info.DisplayName.StartsWith("RA ") && !string.IsNullOrEmpty(info.DefaultBinding))
// We skip TAStudio analog hotkeys because they have special handling (no other hotkey can trigger when in analog editing mode)
.Where(static info => !(info.DisplayName.StartsWith("Analog ") && info.TabGroup == "TAStudio") && !string.IsNullOrEmpty(info.DefaultBinding))
.Select(static info => info.DefaultBinding)
.ToArray();
Debug.Assert(bindings.Distinct().CountIsExactly(bindings.Length), "Do not default bind multiple hotkeys to the same button combination.");
Expand Down