Skip to content

Exercise 7#14

Merged
borisfoko merged 10 commits intomainfrom
exercise-7
Feb 12, 2021
Merged

Exercise 7#14
borisfoko merged 10 commits intomainfrom
exercise-7

Conversation

@Mkohl2508
Copy link
Copy Markdown
Contributor

@medizinmensch
Copy link
Copy Markdown
Contributor

Hi team!
Thanks for this PR!

The "pre-merge" was perfect, the "Files Changed" tab is very clean ⭐
The API connection works, the tests look good. ⭐ ⭐
Frontend tests are passing, responses are mocked. ⭐
Also:

⭐ ⭐ For a login feature in your webapp including a Vue component and its software tests.
⭐ ⭐ For a menu component which shows a login or logout button and its software tests.
⭐ For an upvote button that behaves according to the authentication state of your user
⭐ For a delete and edit button that is only visible to the author of the post.

Sadly, I see issues with the last two.
First, the Lighthouse reporting clearly shows that your PWA is not setup. Your nuxt.config reflects this. (See the "Installable" Section) ❌

Lighthouse reporting

Lastly, your review for TheCodeNinjas is too scarce to give you a point. See the requirements in the instructions. ❌

That makes 11/13 ⭐

Fast perfekt

@borisfoko borisfoko merged commit 9886d3a into main Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants