Skip to content

Conversation

@jetbrains-junie
Copy link
Contributor

📌 Hey! This PR was made for you with Junie, the coding agent by JetBrains Early Access Preview

It's still learning, developing, and might make mistakes. Please make sure you review the changes before you accept them.
We'd love your feedback — join our Discord to share bugs, ideas: here.

📊 Junie Summary

The solution implements automatic disabling of the PHP Composer "Synchronize IDE settings with composer.json" setting when the Moodle framework is enabled. It uses reflection to interact with the PHP Composer settings service and updates the plugin version to 2.2.1. The changes were integrated into MoodleSettingsForm.apply() and documented without user-visible UI alterations.

 The solution implements automatic disabling of the PHP Composer "Synchronize IDE settings with composer.json" setting when the Moodle framework is enabled. It uses reflection to interact with the PHP Composer settings service and updates the plugin version to 2.2.1. The changes were integrated into MoodleSettingsForm.apply() and documented without user-visible UI alterations.
@AviMoto
Copy link
Contributor

AviMoto commented Oct 16, 2025

@jetbrains-junie please add relevant unittest and ui tests

@jetbrains-junie
Copy link
Contributor Author

Hey, it’s Junie by JetBrains! I started processing your request 🚀

…able

Unit and UI tests were added to verify disabling Composer sync when enabling Moodle framework. A test double for Composer settings and new tests validate behavior hermetically without real dependencies. The changelog was updated; test runs timed out in the current environment but compile successfully.
@jetbrains-junie
Copy link
Contributor Author

✅ The execution was successful

test(moodle): add unit and UI tests for composer sync disable

Unit and UI tests were added to verify disabling Composer sync when enabling Moodle framework. A test double for Composer settings and new tests validate behavior hermetically without real dependencies. The changelog was updated; test runs timed out in the current environment but compile successfully.

More information:

@github-actions
Copy link

github-actions bot commented Oct 16, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@AviMoto
Copy link
Contributor

AviMoto commented Oct 16, 2025

@jetbrains-junie
I check the changes and even when the Moodle framework is enable still File | Settings | PHP | Composer | Syncronized IDE Settings with composer.json is checked, the expoexted result that it will be unchecked

@jetbrains-junie
Copy link
Contributor Author

Hey, it’s Junie by JetBrains! I started processing your request 🚀

The Composer sync toggle was fixed to reliably disable "Synchronize IDE settings with composer.json" when enabling the Moodle framework. The code was improved to handle both project-level and application-level Composer settings via reflection. Unit tests were updated, and verification steps were provided.
@jetbrains-junie
Copy link
Contributor Author

✅ The execution was successful

fix(settings): reliably disable composer sync for Moodle

The Composer sync toggle was fixed to reliably disable "Synchronize IDE settings with composer.json" when enabling the Moodle framework. The code was improved to handle both project-level and application-level Composer settings via reflection. Unit tests were updated, and verification steps were provided.

More information:

@AviMoto
Copy link
Contributor

AviMoto commented Oct 16, 2025

@jetbrains-junie find programable why to change to when the Moodle framework enable . Please write the relevant testing and UI testing to validate the functoinality

@jetbrains-junie
Copy link
Contributor Author

Hey, it’s Junie by JetBrains! I started processing your request 🚀

The solution implements a robust method to disable PHP Composer synchronization when the Moodle framework is enabled, using reflection to handle multiple plugin versions. Unit and UI tests were added to verify disabling Composer sync functionality and idempotency. The changes avoid hard dependencies on PHP plugin APIs and support real environment persistence without user interface changes.
@jetbrains-junie
Copy link
Contributor Author

✅ The execution was successful

feat(settings): disable Composer sync when Moodle enabled

The solution implements a robust method to disable PHP Composer synchronization when the Moodle framework is enabled, using reflection to handle multiple plugin versions. Unit and UI tests were added to verify disabling Composer sync functionality and idempotency. The changes avoid hard dependencies on PHP plugin APIs and support real environment persistence without user interface changes.

More information:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

junie - Disable PHP > Composer > Synchronize IDE Settings with composer.json

2 participants