Fix codegen for directly returning new primitive arrays#208
Open
binawoh-sudo wants to merge 1 commit into
Open
Fix codegen for directly returning new primitive arrays#208binawoh-sudo wants to merge 1 commit into
binawoh-sudo wants to merge 1 commit into
Conversation
binawoh-sudo
force-pushed
the
fix-return-new-array-codegen
branch
from
97cb76d to
4bd16aa
Compare
The code generator already handled primitive arrays returned through a local variable, but rejected the equivalent direct return form from issue Syncleus#66. This emits a local array declaration before returning it so direct new-array returns follow the same generated OpenCL shape as the existing workaround. Constraint: Existing codegen tests compare exact OpenCL strings. Rejected: Only remove the explicit exception guard | the writer still needed a local array name to return. Confidence: medium Scope-risk: narrow Tested: git diff --check Not-tested: Maven target tests attempted but blocked before project tests by scala-maven-plugin/Jansi NoSuchMethodError in the local toolchain.
binawoh-sudo
force-pushed
the
fix-return-new-array-codegen
branch
from
4bd16aa to
21b63e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66.
This allows codegen for direct primitive array returns such as:
The writer now emits a local primitive array declaration before returning it, matching the existing supported workaround where the array is assigned to a local variable first.
Updated the Return*ArrayNew codegen tests for all primitive array types.
Tested:
git diff --checkNot tested:
scala-maven-plugin/JansiNoSuchMethodErrorin this local toolchain.