Fix returning newly instantiated arrays#197
Open
rafael226 wants to merge 2 commits into
Open
Conversation
Author
|
Expanded the fix to cover direct returns for all primitive array types, including boolean. The implementation now derives the emitted return-array type from the method return type and the tests share a common expected-OpenCL helper to keep coverage consistent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66.
This changes code generation for
return new <primitive>[size]so it emits the newly-created array as a local temporary and returns that temporary, matching the workaround pattern that already compiled.What changed:
I_NEWARRAYunderReturnwithout throwingCodeGenExceptionnewarraydescriptor mapping for local array declarationsValidated locally with:
Local note: the project POM contains
-XX:MaxPermSize=512m, which JDK 17 rejects, so I removed that flag only for the local validation run and restoredpom.xmlafterward.