ci: honor RUN_TESTS flag on Travis#190
Open
yejingyan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #95.
The Travis matrix defines
RUN_TESTS=trueglobally, but the Khronos ICD jobs usedRUN_TEST=falsewhile also having no explicitscript:section. Because Travis defaults to runningmvn test, those jobs could still execute the test suite and skip OpenCL-dependent tests even though the job was intended to build without running tests.This patch:
RUN_TESTS=false, matching the global variable name;script:section that runsmvn testonly whenRUN_TESTS=true;mvn -DskipTests packagefor the non-test Khronos ICD jobs.Validation:
mvn -q -DskipTests packagegrep -n "RUN_TEST" .travis.ymlconfirms onlyRUN_TESTSis used.