Include private superclass fields in kernel struct#189
Open
KingParmenides wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15.
This updates kernel field discovery so non-static primitive, array, and AtomicInteger fields declared on a superclass are retained even when they are private. Those fields can be referenced from superclass methods that are part of the generated kernel call graph, so they need to be included in This_s.
A regression test covers private superclass fields being present both in the entrypoint referenced fields and in the emitted This_s struct.
Validation:
BTC payout address: 39Q34P8A7g375yqEr8buvNJkUbRgKfbKQZ