Fix synthetic long local declarations#188
Open
KingParmenides wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10.
When Aparapi has to synthesize a local variable table for bytecode compiled without
-g, long locals were recorded with descriptorL. In JVM descriptors,Lstarts an object reference type; scalar long isJ. That made the generated OpenCL omit the declaration for locals such aslong seed = (long) idx;, producing output likel_3 = (long)i_1;.Changes
J.-g:noneand checks that the generated OpenCL declareslong l_3for the cast-initialized local.Verification
I also ran the full test suite. It reaches 576 tests but fails three existing runtime tests in this environment while repeatedly reporting that the OpenCL native library/device is unavailable:
ArrayTest,AccessGetterSetterTest, andCallStaticFromAnonymousKernelTest.If the bounty is still active and BTC payment is available:
39Q34P8A7g375yqEr8buvNJkUbRgKfbKQZ.