Fix primitive boolean field lookup#17
Open
gshaowei6 wants to merge 1 commit into
Open
Conversation
Author
|
Additional validation after opening the PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Syncleus/aparapi#91.
Primitive instance boolean kernel fields currently fail before OpenCL execution because the native argument reader looks up the Java field with JNI signature
Band reads it viaGetByteField. Java boolean fields use signatureZ, so a kernel likeprivate boolean isInverse = true;throwsNoSuchFieldError: ... isInverse Bon the GPU path.This matches the existing static boolean path, which already uses
ZandGetStaticBooleanField, and keeps the OpenCL argument size unchanged becausejbooleanis still passed as the one-byte scalar used by the generatedcharkernel argument.Validation performed:
NoSuchFieldError ... isInverse B.charargument andif (this->isInverse!=0).git diff --check.