Fix primitive boolean field lookup#15
Open
minyanyi wants to merge 1 commit into
Open
Conversation
Author
|
I also verified the native fix locally on Windows x64 with VS Build Tools 2022. Build notes:
Repro/control:
After fix:
So the failing boolean field lookup is resolved by changing the non-static primitive boolean JNI lookup from descriptor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the native runtime lookup for primitive boolean kernel fields.
Aparapi currently maps the generated OpenCL argument to a byte-sized value, but the Java field itself still has the JVM boolean descriptor
Z. The non-static primitive boolean path was looking up the field with descriptorBand reading it as a byte, which causesNoSuchFieldErrorfor kernels like Syncleus/aparapi#91.This matches the existing static boolean path by looking up descriptor
Zand reading the value withGetBooleanField.Verification:
NoSuchFieldError: ...BooleanKernel.isInverse B.Bwhile the static boolean path already usedZ.git show --checkpasses.I could not build the native library in this Windows environment because no C++ compiler or Docker runtime is installed.