Skip to content

Conversation

@JafarAli3783
Copy link

Feature description

Task - 971964 - Improvements on EJ2 File Manager directory upload feature.

Requirement and specification document

Feature scope and impact

  • Core functionality (high impact)
  • Enhancement to existing feature
  • New standalone feature
  • Experimental feature

Output screenshots/demos

Upload functionality using context menu,
image.png

Folder upload,
image.png

File upload,
image.png

After enabling SequentialUpload property,
image.png

Previous behavior or disabling the SequentialUpload property,
image.png

Access control functionality prevented File upload for specific folder,
image.png

Access control functionality prevented Folder upload for specific folder,
image.png

Feature matrix documentation

Testing coverage

  • Ensured in the sample attached in above mentioned task.
  • Ensured the context menu Upload renders it's submenu items Files and Folders properly.
  • Ensured the icons used in the ``Upload` menu items renders properly.
  • Ensured the icons used in the ``FilesandFolders` menu items renders properly.
  • Ensured after clicking the Folder menu item the file explorer opens with properly with folders alone without showing files.
  • Ensured after clicking the File menu item the file explorer opens with properly with files alone without giving a space to upload files.
  • Ensured the directoryUpload property switches properly when selecting Files and Folders consecutively for multiple times.
  • Ensured whether the property works fine in initial rendering and switching it for multiple times.
  • Added the sequentialUpload property and ensured whether the files and folders are uploaded one by one.
  • Ensured in the provider end whether any changes specific to the sequentialUpload is required.
  • Ensured whether the Upload method in the provider end is triggering properly after the first file was uploaded.
  • Ensured whether the Upload method triggers consecutively without enabling the sequentialUpload property.
  • Ensured is it required to pass a boolean variable indicating SequentialUpload to provider client end.
  • Ensured the providers functions different manner while enabling and disabling the sequentialUpload property.
  • Ensured by uploading the multiple files each of different sizes to find out the working of sequentialUpload functionality visibly.
  • Ensured the multiple files with same size and checked whether the files are uploaded one after another when sequentialUpload functionality is enabled.
  • Ensured whether the folder upload is working fine with and without sequential upload functioanality.
  • Ensured whether the sequential upload functionality did not affected the existing normal upload functionality.
  • Ensured whether the sequential upload functionality working fine in physical provider.
  • Ensured whether the sequential upload functionality working fine in amazon s3 provider.
  • Ensured whether the sequential upload functionality working fine in azure provider.
  • Ensured whether the sequential upload functionality working fine in node jsnprovider.
  • Ensured whether the context menu upload functionality working fine in physical provider.
  • Ensured whether the context menu upload functionality working fine in amazon s3 provider.
  • Ensured whether the context menu upload functionality working fine in azure provider.
  • Ensured whether the context menu upload functionality working fine in node js provider.
  • Ensured the access control functionality to specific folder for uploading or preventing the files and folders based on its type.
  • Ensured the access control functionality is working when enabling FilesOnly mode and folder upload is prevented properly.
  • Ensured the access control functionality is working when enabling FoldersOnly mode and file upload is prevented properly.
  • Ensured the AccessDenied message is shown properly for the prevented folder upload.
  • Ensured the AccessDenied message is shown properly for the prevented file upload.
  • Ensured the access control functionality is working fine in physical provider.
  • Ensured the access control functionality is working fine in amazon s3 provider.
  • Ensured the access control functionality is working fine in azure provider.
  • Ensured the access control functionality is working fine in node js provider.
  • Ensured whether the changes made in the Upload method regarding the AccessControl changes is working without any exceptions in physical provider.
  • Ensured whether the changes made in the Upload method regarding the AccessControl changes is working without any exceptions in amazon s3 provider.
  • Ensured whether the changes made in the Upload method regarding the AccessControl changes is working without any exceptions in azure provider.
  • Ensured whether the changes made in the Upload method regarding the AccessControl changes is working without any exceptions in node js provider.
  • Ensured by utilizing the uploadSettings properties.
  • Ensured by utilizing the autoClose property.
  • Ensured by utilizing all the FileManager component events.
  • Ensured whether all the events triggering with a proper arguments values.
  • Ensured whether there is a difference between the events triggering current and previous nuget sample because due to the sequential upload functionality.

Test cases and automation

  • Test cases documented and attached to this PR
  • BUnit tests added (PR link: Automation work assigned to testing team to avoid this in the future)
  • Playwright tests added (PR link: _________________)
  • Manual testing only (justification: _________________)
  • Not applicable

Test bed sample location

Provide the test bed sample location for code reviewers to verify the feature's behavior.

Platform verification

  • Verified in Blazor Server
  • Verified in Blazor WASM
  • Not applicable

Related components

  • Feature applicable to other components (Tasks created: _________________) (tagged "needs-attention-coreteam")
  • Not applicable to other components

Breaking changes

  • Contains breaking changes - provide migration guidance (added "breaking-change" label)
  • No breaking changes

Performance verification

  • Memory usage verified (no leaks)
  • Rendering performance verified
  • Not applicable

Reviewer Checklist

  • Feature matrix documentation verified
  • Test coverage verified
  • Sample implementation reviewed
  • Code meets standards and best practices
  • C# implementation used appropriately (minimal JavaScript)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant