Open
Conversation
cjmyers
reviewed
Feb 1, 2019
Contributor
cjmyers
left a comment
cjmyers
left a comment
There was a problem hiding this comment.
Did you mean to eliminate the manifests?
Contributor
Author
|
Yes. They are automatically generated at build-time, so no reason to keep them. |
Contributor
|
There is an issue which is that not every file in those directories should be in the manifest. In particular, the GenBank directory has several that we need to skip. Also, there are non-SBOL or SBOL-like files that should be ignored. |
cjmyers
approved these changes
Feb 1, 2019
Contributor
cjmyers
left a comment
cjmyers
left a comment
There was a problem hiding this comment.
Please check. Should probably work, since GenBank files not part of SBH tests
jamesamcl
approved these changes
Jun 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the generation of manifests into the maven build process. It also removes and .gitignores the files. This should resolve issue with the manifests and filetree getting out of sync.