doc(OpenShift): add full minimal example#4230
Merged
Conversation
All changes are between markers. The example is based out of the minimal example provided with Renku.
sgaist
force-pushed
the
doc/add-configuration-for-openshift
branch
from
0bb41b1 to
9ca989c
Compare
olevski
requested changes
Feb 11, 2026
Member
olevski
left a comment
olevski
left a comment
There was a problem hiding this comment.
Thanks Samuel this looks really good. Just one small question. I am happy if we merge even without resolving it.
olevski
requested changes
Feb 12, 2026
Comment on lines
+426
to
+431
| # added | ||
| rbac: | ||
| create: false | ||
|
|
||
| localClusterSessionServiceAccount: renku-amalthea-sessions-scc-handler | ||
| # end added |
Member
There was a problem hiding this comment.
What is the purpose of these # added and # end added comments that are scattered throughout. I think these are leftovers from some check that we can get rid off?
Member
There was a problem hiding this comment.
There are a few more scattered throughout these 2 are not the only ones.
Collaborator
Author
There was a problem hiding this comment.
I used them to separate the values that are required for Renku to run on OpenShift.
I thought it would allow readers to compare more easily a values file used to deploy on vanilla kubernetes VS OpenShift.
olevski
approved these changes
Feb 16, 2026
aledegano
pushed a commit
that referenced
this pull request
Feb 18, 2026
* chore: update from notation to ingressClassName * doc(OpenShift): add full minimal example All changes are between markers. The example is based out of the minimal example provided with Renku.
aledegano
pushed a commit
that referenced
this pull request
Feb 18, 2026
* chore: update from notation to ingressClassName * doc(OpenShift): add full minimal example All changes are between markers. The example is based out of the minimal example provided with Renku.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds a complete minimal example of values file. By minimal,
As a drive-by fix, the
sessionIngressconfiguration has been updated to make use ofingressClassNamein place of the deprecated annotation.