Skip to content

feat: use allow list for rclone#1202

Merged
leafty merged 6 commits intomainfrom
leafty/allow-list-rclone
Feb 11, 2026
Merged

feat: use allow list for rclone#1202
leafty merged 6 commits intomainfrom
leafty/allow-list-rclone

Conversation

@leafty
Copy link
Copy Markdown
Member

@leafty leafty commented Feb 2, 2026

Update rclone validation to use an allow list system:

  • All storage types are listed and are explicitly allowed or blocked
  • For all allowed storage types, all options are marked as allowed or blocked

This update also blocks potentially unsafe options (referring to a local file or a potential arbitrary command).

Tests in test/components/renku_data_services/storage/test_rclone.py are designed to help maintain the configuration of allowed storage types and storage options.

/deploy

@RenkuBot
Copy link
Copy Markdown
Contributor

RenkuBot commented Feb 2, 2026

You can access the deployment of this PR at https://renku-ci-ds-1202.dev.renku.ch

@leafty leafty marked this pull request as ready for review February 2, 2026 14:36
@leafty leafty requested review from a team, SalimKayal and sgaist as code owners February 2, 2026 14:36
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: the new tests in this file can help maintainers update the list of allowed storage types and allowed storage options.

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 2, 2026

Pull Request Test Coverage Report for Build 21900087723

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 40 of 42 (95.24%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on leafty/allow-list-rclone at 89.077%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/data_connectors/doi/schema_org.py 0 2 0.0%
Totals Coverage Status
Change from base Build 21623169484: 89.1%
Covered Lines: 23593
Relevant Lines: 26486

💛 - Coveralls

@leafty leafty enabled auto-merge (squash) February 11, 2026 09:44
@leafty leafty merged commit 308f0a0 into main Feb 11, 2026
26 of 27 checks passed
@leafty leafty deleted the leafty/allow-list-rclone branch February 11, 2026 10:05
@RenkuBot
Copy link
Copy Markdown
Contributor

Tearing down the temporary RenkuLab deployment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants