Skip to content

add suggestion for when job logs are missing#72

Merged
Panaetius merged 1 commit intomainfrom
job-log-suggestion
Mar 16, 2026
Merged

add suggestion for when job logs are missing#72
Panaetius merged 1 commit intomainfrom
job-log-suggestion

Conversation

@Panaetius
Copy link
Member

No description provided.

@Panaetius Panaetius requested a review from a team as a code owner March 16, 2026 09:44
@github-actions
Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Improve error message with retry suggestion

Add a helpful suggestion to the error message to inform users that logs may not be
immediately available and to retry later.

coman/src/cscs/handlers.rs [189-195]

 if path.is_empty() {
     return Err(eyre!(
         "No {} log exists for job {}",
         if stderr { "stderr" } else { "stdout" },
         job_id
-    ));
+    ))
+    .suggestion("It might take a while for the log to be created, try again later");
 }
Suggestion importance[1-10]: 8

__

Why: This suggestion enhances the error message by adding a helpful suggestion to inform users that logs may not be immediately available, which improves user experience and reduces support requests. The change is semantically correct and directly addresses a potential usability issue.

Medium

@Panaetius Panaetius merged commit 48e58fa into main Mar 16, 2026
3 checks passed
@Panaetius Panaetius deleted the job-log-suggestion branch March 16, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant