This repository was archived by the owner on Sep 6, 2018. It is now read-only.
Closed
Conversation
djbe
suggested changes
Mar 12, 2017
Member
There was a problem hiding this comment.
Hi Carlos,
Thank you for the PR. This feature has been requested a few times before, so you might want to read through those issues / PRs:
Especially the latter, go through the code and the comments, many points have already been discussed there. Another good starting point is the Reusable library, which you can find here: https://github.com/AliSoftware/Reusable
Couple of points:
- support collection views
- support reusable views such as header/footer views
- XIB support
- macOS support?
- (eventually) ensure all tests pass, you can test this locally using
rake xcode:test
At some point you'll have to create a related PR in the templates repository, for modifying the contexts, templates and output. When you reach that point, we can help you get everything in order.
Open
Author
|
I close it in favor of #16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.