test: fix CI failures for allowedColors deprecation #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeylong
force-pushed
the
fix/ci-test-failures
branch
from
c7fda43 to
c1e5ec6
Compare
- Remove allowedColors from validate-portability fixture contract - Keeps portability test focused on tarball install, not deprecation - Maintains 0 warnings expectation - Add createTempWorkspace helper to color-deprecation tests - Creates minimal valid workspace with proper structure - Includes contract-container, sections, fonts, motion, layout - Ensures tests validate against real workspace structure - Update color-deprecation test assertions - Allow warnings >= 1 instead of exact count - Assert no schema errors for color policy test - Use --workspace-root for proper validation These changes reflect the new allowedColors deprecation behavior while keeping tests focused on their specific concerns.
mikeylong
force-pushed
the
fix/ci-test-failures
branch
from
c1e5ec6 to
834c0f5
Compare
Fixes pageFrame test failures caused by deprecated allowedColors field. Tests were expecting exit code 0 but getting exit code 2 due to deprecation warnings/errors.
- Add apps/test-surface/app/ directory structure to all fixtures - Create globals.css with required declarations (fonts, colors, motion, layout) - Create page.tsx with section markers for each fixture - Fix inline-styles: use string style prop instead of JSX object - Fix maxwidth-fail: use string style prop with 1400px - Fix css-rule: add CSS variable and import globals.css in layout - Fix font-family: remove 'sans-serif' from non-allowed fonts These changes ensure fixtures have complete workspace structure required for validation, similar to color-deprecation test fixes. All 6 pageFrame tests now passing (tests 54-59).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CI test failures related to allowedColors deprecation.
Changes
validate-portability.test.mjs
allowedColorsfrom fixture contractcolor-deprecation.test.mjs
createTempWorkspacehelper functionTest Results
These changes reflect the new allowedColors deprecation behavior while keeping tests focused on their specific concerns.