Skip to content

Swarm certification#422

Closed
k3dz0r wants to merge 4 commits into
developfrom
2026-04-20
Closed

Swarm certification#422
k3dz0r wants to merge 4 commits into
developfrom
2026-04-20

Conversation

@k3dz0r
Copy link
Copy Markdown
Collaborator

@k3dz0r k3dz0r commented Apr 20, 2026

Summary by CodeRabbit

  • Documentation

    • Improved formatting and consistency in CLI guides for S3 and vLLM deployment instructions
    • Updated expected output descriptions for clearer deployment verification steps
    • Added comprehensive documentation on swarm certification, cryptographic onboarding, and PKI-based trust model for secure node validation
  • Chores

    • Updated dependency configurations

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

Warning

Rate limit exceeded

@k3dz0r has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 50 minutes and 58 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 50 minutes and 58 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9b96ff41-138a-4e03-8de6-c4b7bb37c92a

📥 Commits

Reviewing files that changed from the base of the PR and between fe1fa56 and 2eb4b18.

📒 Files selected for processing (1)
  • package.json

Walkthrough

Documentation pages for CLI guides have been updated with formatting corrections and clearer instructions. A comprehensive new guide on swarm certification and PKI trust model has been added. Additionally, webpack dependency has been pinned to version 5.98.0 in package.json.

Changes

Cohort / File(s) Summary
CLI Documentation Updates
docs/cli/Guides/swarm-vllm-s3.md, docs/cli/Guides/swarm-vllm.md
Fixed inline formatting with bold emphasis for UI labels, normalized command indentation, and updated expected output descriptions from plural to singular item expectations. Rephrased DNS instructions for clarity.
Certification Documentation
docs/fundamentals/swarm-certification.md
New comprehensive guide documenting Super Swarm's cryptographic onboarding, PKI-based trust model, certificate hierarchy, network modes (trusted/untrusted), and worker node onboarding phases for confidential VM attestation and secure key retrieval.
Dependency Configuration
package.json
Added top-level overrides field pinning webpack to version 5.98.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Poem

🐰 With whiskers twitched and paws so light,
I've polished docs from wrong to right—
Bold labels shine, DNS flows clear,
New PKI knowledge, crisp and dear!
Webpack locked tight at 5.98,
These changes celebrate, no debate!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Swarm certification' accurately summarizes the primary change: adding comprehensive documentation about Super Swarm's cryptographic onboarding and PKI-based trust model, along with supporting documentation updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-04-20

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (1)
docs/fundamentals/swarm-certification.md (1)

28-28: Add a direct cross-reference for the trusted measurements registry.

“Currently hosted on GitHub” is too vague for operators; please add an explicit link using the docs’ established cross-referencing style so readers can locate the registry immediately.

As per coding guidelines, "Follow the established cross-referencing pattern with custom anchor tags".

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/fundamentals/swarm-certification.md` at line 28, Update the "trusted"
definition to include a direct cross-reference to the measurements registry by
adding the established docs-style link with a custom anchor tag; locate the
paragraph containing the `trusted` term and replace "currently hosted on GitHub"
with a cross-reference using the repository anchor (follow existing pattern used
elsewhere in docs, e.g., `<xref:anchor-name>` or the project's custom anchor
syntax) that points to the trusted measurements registry so operators can jump
directly to the registry entry.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/cli/Guides/swarm-vllm.md`:
- Line 141: Update the sentence that currently reads "At your DNS provider, add
a CNAME record pointing to the hostname and a TXT record for domain
verification." to explicitly instruct creating those DNS records for each
required hostname (referencing the sentence "At your DNS provider, add a CNAME
record pointing to the hostname and a TXT record for domain verification.");
change "the hostname" to "each hostname" and add a short clarifying clause such
as "create a CNAME and corresponding TXT verification record for each required
hostname" so readers understand to provision records for both hostnames
mentioned earlier.

In `@docs/fundamentals/swarm-certification.md`:
- Around line 74-76: The two diagram <img> elements (e.g., <img
src={require('./images/swarm-certification-phase1.png').default} .../>) are
missing alt attributes; update both image tags (the phase1 and the other diagram
around lines 91-93) to include descriptive alt text that conveys the diagram
purpose (e.g., alt="Swarm certification phase 1 diagram") to improve
accessibility and non-visual consumption.

In `@package.json`:
- Around line 60-62: The package.json override pins webpack to "5.98.0", which
is vulnerable; update the "overrides" entry for the "webpack" key to at least
"5.104.1" (preferably the latest stable 5.x such as "5.106.2") so the project
uses a patched webpack release; locate the "overrides" object and change the
value of the "webpack" property accordingly and run install to refresh
lockfiles.

---

Nitpick comments:
In `@docs/fundamentals/swarm-certification.md`:
- Line 28: Update the "trusted" definition to include a direct cross-reference
to the measurements registry by adding the established docs-style link with a
custom anchor tag; locate the paragraph containing the `trusted` term and
replace "currently hosted on GitHub" with a cross-reference using the repository
anchor (follow existing pattern used elsewhere in docs, e.g.,
`<xref:anchor-name>` or the project's custom anchor syntax) that points to the
trusted measurements registry so operators can jump directly to the registry
entry.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9fc53b38-6da9-4d3a-a127-8f65b83c93e9

📥 Commits

Reviewing files that changed from the base of the PR and between 2bc4dd0 and fe1fa56.

⛔ Files ignored due to path filters (8)
  • docs/cli/images/swarm-ingresses-s3-verified.png is excluded by !**/*.png
  • docs/cli/images/swarm-ingresses-s3.png is excluded by !**/*.png
  • docs/cli/images/swarm-ingresses-vllm-verified.png is excluded by !**/*.png
  • docs/cli/images/swarm-ingresses-vllm.png is excluded by !**/*.png
  • docs/cli/images/swarm-policy-rules-grant-access.png is excluded by !**/*.png
  • docs/fundamentals/images/swarm-certification-phase1.png is excluded by !**/*.png
  • docs/fundamentals/images/swarm-certification-phase2.png is excluded by !**/*.png
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (4)
  • docs/cli/Guides/swarm-vllm-s3.md
  • docs/cli/Guides/swarm-vllm.md
  • docs/fundamentals/swarm-certification.md
  • package.json

Comment thread docs/cli/Guides/swarm-vllm.md
Comment thread docs/fundamentals/swarm-certification.md
Comment thread package.json
@k3dz0r k3dz0r closed this Apr 20, 2026
@k3dz0r k3dz0r deleted the 2026-04-20 branch April 20, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant