-
Notifications
You must be signed in to change notification settings - Fork 6
Merge staging into develop #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Upload guide
Merge branch develop into staging
WalkthroughConditional Docker image tags were added to two GitHub Actions workflow files. When the workflow runs on the main branch, it now appends both a static "mainnet" tag and a dynamic "mainnet-build-{run_id}" tag to the Docker image metadata. No other workflow logic or exported entities were changed. Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/docker-image.yml (1)
43-44: Validate that conditional tag expansion does not breakdocker/metadata-action.
docker/metadata-actionnormally ignores empty lines, but when the condition is false these expressions still emit a blank line inside the multi-line string. Please confirm that v5 continues to treat empty lines as no-ops; otherwise, the build may fail with “invalid tag format”.${{ github.ref == 'refs/heads/main' && 'type=raw,value=mainnet' || '' }} ${{ github.ref == 'refs/heads/main' && format('type=raw,value=mainnet-build-{0}', github.run_id) || '' }}If this proves brittle you could instead wrap the whole step in
if: github.ref == 'refs/heads/main'and append the additional tags only when needed, avoiding the empty-line edge case altogether..github/workflows/build-manual.yml (1)
54-55: Keep action versions aligned to avoid divergent behaviour.These new conditional tags mirror the previous workflow, but this file still uses
docker/metadata-action@v4(see line 43) while the other workflow is on v5. To minimise future surprises, upgrade here as well:- uses: docker/metadata-action@v4 + uses: docker/metadata-action@v5v5 contains several bug-fixes around tag sanitisation that could affect the new
mainnet*raw tags.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/build-manual.yml(1 hunks).github/workflows/docker-image.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-and-push-image
Summary by CodeRabbit