Skip to content

Conversation

@DmitrySmv
Copy link
Contributor

@DmitrySmv DmitrySmv commented Jul 9, 2025

Summary by CodeRabbit

  • Chores
    • Updated Docker image tagging in GitHub Actions workflows to include additional mainnet-specific tags for builds on the main branch. This enhances identification and traceability of main branch Docker images.

@DmitrySmv DmitrySmv requested a review from Idris0v July 9, 2025 11:41
@coderabbitai
Copy link

coderabbitai bot commented Jul 9, 2025

Walkthrough

Conditional Docker image tags were added to two GitHub Actions workflow files. When the workflow runs on the main branch, it now appends both a static "mainnet" tag and a dynamic "mainnet-build-{run_id}" tag to the Docker image metadata. No other workflow logic or exported entities were changed.

Changes

File(s) Change Summary
.github/workflows/build-manual.yml Added conditional Docker image tags: "mainnet" and "mainnet-build-{run_id}" for main branch runs.
.github/workflows/docker-image.yml Appended same conditional Docker image tags for main branch: "mainnet" and "mainnet-build-{run_id}".

Poem

From the warren, a workflow tune,
Tags for mainnet now festoon,
With each build run, a name anew,
"mainnet" and its number too.
Docker images hop with pride,
As branches flow and tags collide.
🐇✨


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/docker-image.yml (1)

43-44: Validate that conditional tag expansion does not break docker/metadata-action.

docker/metadata-action normally ignores empty lines, but when the condition is false these expressions still emit a blank line inside the multi-line string. Please confirm that v5 continues to treat empty lines as no-ops; otherwise, the build may fail with “invalid tag format”.

${{ github.ref == 'refs/heads/main' && 'type=raw,value=mainnet' || '' }}
${{ github.ref == 'refs/heads/main' && format('type=raw,value=mainnet-build-{0}', github.run_id) || '' }}

If this proves brittle you could instead wrap the whole step in if: github.ref == 'refs/heads/main' and append the additional tags only when needed, avoiding the empty-line edge case altogether.

.github/workflows/build-manual.yml (1)

54-55: Keep action versions aligned to avoid divergent behaviour.

These new conditional tags mirror the previous workflow, but this file still uses docker/metadata-action@v4 (see line 43) while the other workflow is on v5. To minimise future surprises, upgrade here as well:

-        uses: docker/metadata-action@v4
+        uses: docker/metadata-action@v5

v5 contains several bug-fixes around tag sanitisation that could affect the new mainnet* raw tags.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9298c14 and 4885b5b.

📒 Files selected for processing (2)
  • .github/workflows/build-manual.yml (1 hunks)
  • .github/workflows/docker-image.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build-and-push-image

@DmitrySmv DmitrySmv merged commit 8e28997 into develop Jul 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants