Redesign settings page with scope-based visual separation#51
Closed
SunkenInTime wants to merge 1 commit intosetting-overhaulfrom
Closed
Redesign settings page with scope-based visual separation#51SunkenInTime wants to merge 1 commit intosetting-overhaulfrom
SunkenInTime wants to merge 1 commit intosetting-overhaulfrom
Conversation
- Split settings into two visually distinct scope cards: 'This Strategy' (per-page, violet accent) and 'Global' (app-wide, neutral) - Each card has scope badge, icon, description, and colored top accent bar - Split map theme section: Active Theme in strategy card, Profile Library in global - Made ActiveThemeCard and ProfileLibrarySection public widgets - Compact sliders with value display, refined checkbox rows - Section dividers with uppercase labels for sub-grouping within cards - Shows helpful message when no strategy is open - Consistent with existing shadcn tacticalViolet theme Co-authored-by: Dara Adedeji <SunkenInTime@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Visual overhaul of the Settings page to make it immediately clear whether you're editing per-strategy or global settings.
Changes
New scope card layout — Settings are organized into two visually distinct containers:
PER PAGEbadge) — Contains Agent Scale, Ability Scale, and Active Map Theme. Only affects the current page.APP-WIDEbadge) — Contains Map Overlays, New Strategy Defaults, and Theme Profiles. Applies app-wide.Design details:
MAP THEME,MAP OVERLAYS,NEW STRATEGY DEFAULTS,THEME PROFILES) group settings within each cardRefactoring:
ActiveThemeCardandProfileLibrarySectionextracted as public widgets frommap_theme_settings_section.dartso they can be placed in separate scope cardsMapThemeSettingsSectionkept for backward compatibilityDesign principles
tacticalVioletTheme— usesprimary,card,border,mutedForeground,secondarycolors