refactor: enhance git command execution robustness in add_new_entry.py#1028
Open
RinZ27 wants to merge 1 commit intoSunWeb3Sec:mainfrom
Open
refactor: enhance git command execution robustness in add_new_entry.py#1028RinZ27 wants to merge 1 commit intoSunWeb3Sec:mainfrom
RinZ27 wants to merge 1 commit intoSunWeb3Sec:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the
GitManagerclass to avoid relying on shell expansion andshell=Truewhen retrieving Solidity files. Usingshell=Truewith string interpolation is generally a brittle practice, especially when dealing with path specifications. By switching to argument lists (array-based) and implementing manual.solfiltering in Python, we make the internal utility script significantly more stable and predictable across different environments.Running
git ls-filesandgit diffdirectly with the target directory ensures that the file discovery logic remains precise. I've also added basic error handling for subprocess calls to prevent the script from crashing if a git command fails. These changes keep the maintainer workflow robust while maintaining the original functionality of the script.