Fix SE4 changelog URL casing#10768
Closed
Ironship wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes update-check failures for legacy Subtitle Edit 4.x clients by ensuring the repository-hosted changelog filename matches the hard-coded URL casing, and removes an obsolete fallback URL from the SE 5 update checker.
Changes:
- Added/renamed the root changelog to
Changelog.txt(capital C, rest lower) so SE4’s update-check URL resolves again. - Updated SE5 update-check logic to remove the now-dead
ChangeLog.txtfallback URL. - Updated solution/workflow references to point at the correctly cased changelog filename.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/ui/Features/Help/CheckForUpdates/CheckForUpdatesViewModel.cs |
Removes ChangeLog.txt fallback URL and returns “unable to check” when both remaining URLs fail. |
SubtitleEdit.sln |
Updates Solution Items entry from ChangeLog.txt to Changelog.txt. |
Changelog.txt |
Introduces the correctly cased changelog file at repo root for SE4 update checks. |
.github/workflows/build-ui.yml |
Updates release-notes “Change Log” link to Changelog.txt. |
17228c2 to
046861c
Compare
Member
|
I will merge this in a week or two, as this will break the SE 5 beta updates for versions before beta21. |
|
Thank you niksedk it is much appreciated and such a great program. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChangeLog.txttoChangelog.txtso the hard-coded SE 4 update-check URL resolves again.change-log.txtfirst.change-log.txtURL and update the solution item.Fixes #10540.
Verification
https://raw.githubusercontent.com/SubtitleEdit/subtitleedit/main/Changelog.txtfor update checks.change-log.txtraw URL returns 200 (SE 5 primary URL)Changelog.txtraw URL returns 200 (SE 4 hard-coded URL)ChangeLog.txtraw URL returns 404 after the renamedotnet build .\src\ui\UI.csproj -c Debug --no-restoresucceeded with 3 existing nullability warnings in unrelated export/batch-convert files.dotnet test .\tests\UI\UITests.csproj -c Debug --no-restore -v minimalpassed: 124/124.Notes
change-log.txtremains available and is the first URL used by the SE 5 checker.ChangeLog.txtandChangelog.txt) would be the broadest URL compatibility option, but it would require tracking case-only duplicate files, which is risky for Windows contributors.