Skip to content

Add support for Jokes in Hungarian #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
furdiburd wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for Jokes in Hungarian #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion app/src/main/kotlin/org/stypox/dicio/skills/joke/JokeSkill.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,13 @@ class JokeSkill(correspondingSkillInfo: SkillInfo, data: StandardRecognizerData<
setup = joke.getString("setup"),
delivery = joke.getString("punchline")
)
// Hungarian API uses "title" / "text" instead of "setup" / "delivery"
} else if (locale == "hu") {
val joke: JSONObject = ConnectionUtils.getPageJson(RANDOM_JOKE_URL_HU)
return JokeOutput.Success(
setup = joke.getString("title"),
delivery = joke.getString("text")
)
} else {
val joke: JSONObject = ConnectionUtils.getPageJson(
"$RANDOM_JOKE_URL?lang=$locale&safe-mode&type=twopart"
Expand All @@ -37,8 +44,9 @@ class JokeSkill(correspondingSkillInfo: SkillInfo, data: StandardRecognizerData<
companion object {
private const val RANDOM_JOKE_URL = "https://v2.jokeapi.dev/joke/Any"
private const val RANDOM_JOKE_URL_EN = "https://official-joke-api.appspot.com/random_joke"
private const val RANDOM_JOKE_URL_HU = "https://viccgyujt-api.anoim.workers.dev/random-vicc"
val JOKE_SUPPORTED_LOCALES = listOf(
"cs", "de", "en", "es", "fr", "pt"
"cs", "de", "en", "es", "fr", "hu", "pt"
)
}
}
6 changes: 6 additions & 0 deletions app/src/main/sentences/hu/joke.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
command:
- mondj|mesélj egy|még egy? jó|vicces? vicc<et?>|poént|tréfá<t?>
- (tudsz valami vicceset)|(tudsz egy viccet)|(van egy jó vicc<ed?>)
- (nevettess meg)|(szórakoztass)|(vidíts fel) (egy|még egy? jó|vicces? vicc<cel?>)?
- mondj valami vicces<et?>|mulatságos<at?>
- (kérlek egy vicc<et?>)|(hallgassunk egy vicc<et?>)