Open
Conversation
Saying "at" this folder level could be taken as meaning *exactly* at that level, i.e., not descending into subfolders. The forEach() method does in fact descend, so say "at or below".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks very much for
jszip; it's very useful. This minor suggestion clarifies the summary docstring for theforEach()method. The example in the docs is clear as to the recursive/descending behaviour offorEach(), but I think the current summary could be seen as ambiguous. Thanks!(I didn't change the occurrence in
dist/jszip.jsas it looks like it's a generated file. If I've misunderstood, please comment and I'll update this PR.)