Introduce a PylasuANTLRParser class modeled after Kolasu. #42
Introduce a PylasuANTLRParser class modeled after Kolasu. #42alessiostalla merged 3 commits intomasterfrom
Conversation
…rything was copied from Kolasu, just the bare minimum to have this usable in a project.
ftomassetti
left a comment
ftomassetti
left a comment
There was a problem hiding this comment.
I just added minor comments
| for field in fields: | ||
| if field.name == name and PYLASU_FEATURE in field.metadata: | ||
| feature = field.metadata[PYLASU_FEATURE] | ||
| for fld in fields: |
There was a problem hiding this comment.
Why renaming field into fld?
There was a problem hiding this comment.
It wasn't passing the linter because it shadowed an import
| @@ -0,0 +1 @@ | |||
| from .results import FirstStageParsingResult, ParsingResultWithFirstStage | |||
|
|
||
| You should extend this class to implement the parts that are specific to your language. | ||
|
|
||
| Note: instances of this class are thread-safe and they're meant to be reused. Do not create a new PylasuANTLRParser |
There was a problem hiding this comment.
Does this come verbatim from Kolasu or is this class really thread-safe?
There was a problem hiding this comment.
It comes from Kolasu but I don't see why it shouldn't apply here too
| position=Position(token_end_point(last_token), token_end_point(last_token)) | ||
| ) | ||
| ) | ||
| # TODO Kolasu also traverses the parse tree searching for exceptions |
There was a problem hiding this comment.
Is this something we should do here?
Should we add a test for this? Or perhaps add an issue to come back to this later?
|
|
||
|
|
||
| @dataclass | ||
| class LexingResult(WithIssues): |
There was a problem hiding this comment.
Don't we need also the LexingResult, in case just lexing is invoked?
There was a problem hiding this comment.
We'll need it but it has a different structure in Kolasu, at the moment it's not used (because we don't have the lex methods). I'll open an issue about that too
2 participants
Not everything was copied from Kolasu, just the bare minimum to have this usable in a project.
Fixes #18