Add handling of private apps data#200
Open
Lifeismana wants to merge 3 commits intoSteamDatabase:masterfrom
Open
Add handling of private apps data#200Lifeismana wants to merge 3 commits intoSteamDatabase:masterfrom
Lifeismana wants to merge 3 commits intoSteamDatabase:masterfrom
Conversation
Member
|
I don't want the highlighting to be too overloaded (especially with extra requests), and I'm not entirely sure there's much value for knowing private apps on steamdb site. |
Contributor
Author
|
I also think that highlighting them isn't that useful (that fetchPrivateApps is probably not placed well in regard to that) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved fetching the store token to its own function to dedup but i'm not sure if storing it in local storage should be kept, do we trust users enough to not get it stolen?
I've tested FetchPrivateApps but not SetAppPrivate
I haven't gated this behind an option since, depending of what's made of this, the fetch would fit under "Enable extra filtering on sales page and bundles page" and the set under "Wishlist, follow, and ignore products on the Steam store directly from SteamDB"