test: add test cases for role rotation and update test snapshots for …#340
Open
42natus wants to merge 1 commit into
Open
test: add test cases for role rotation and update test snapshots for …#34042natus wants to merge 1 commit into
42natus wants to merge 1 commit into
Conversation
…initialization and paused state behaviors.
|
@42natus Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Fix workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #304 to establish a deterministic pause policy that prioritizes safety and fairness. Previously, pausing the contract blocked all functionality. We have updated the policy to explicitly allow terminal fund-recovery states to continue operating while the contract is paused.
Changes Made
refund_expiredDuring Pause: Removed theensure_not_pausedconstraint fromrefund_expired. Depositors can now safely reclaim their funds if the deadline passes, even if the contract is paused due to an incident.resolve_disputeDuring Pause: Ensured the arbitrator retains the ability to resolve ongoing disputes while the contract is paused.PausedToggledEventto explicitly emit thecalleraddress,caller_role(Operator), and the blocktimestampto improve traceability of pause events.test_refund_expired_allowed_when_paused) to rigidly enforce that these terminal state functions succeed deterministically when the contract is paused.Related Issues
Closes #304
Verification
refund_expiredlogic inActivevsPausedstates.resolve_disputeoperates correctly under aPausedstate.PausedToggledEventschema compiles and emits correctly.cargo test).