Fixing the string replacement in the helm chart to update the tag instead of the image#144
Merged
Merged
Conversation
…tead of the image
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
asadk23
approved these changes
Jun 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes update_file so Helm chart-style image maps (e.g., {repository: ..., tag: ...}) get their tag updated instead of replacing the entire image field, and adds tests to validate the behavior.
Changes:
- Update
update_filelogic to write.tagwhen the target field is a map containingtagorrepository. - Add an integration-style Bats test that exercises the behavior with a real
yq. - Add a shared test helper to skip integration tests when
yqisn’t available.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
scripts/lib/gitops-functions.sh |
Adjusts map detection logic to update .tag when the map looks like an image map (tag/repository). |
tests/lib-gitops-functions.bats |
Renames/extends tests and adds a real-yq integration test for repository-only maps. |
tests/test_helper/setup.bash |
Adds skip_if_no_yq helper for conditional integration testing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
soemo
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
The action would currently still replace the image and not the tag.
Added some tests using the right yq and not a mocked one to verify the behavior.
Checklist