Skip to content

Conversation

@SplittyDev
Copy link
Owner

@SplittyDev SplittyDev commented Apr 2, 2025

This PR fixes a text encoding/decoding issue in provider-specific badge labels.

Misc

  • Upgrade worker to workers@0.5.0
  • Upgrade wrangler to wrangler@4
  • Update dependencies

Resolved Issues

@vercel
Copy link

vercel bot commented Apr 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spacebadgers ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 5:54am

@SplittyDev SplittyDev requested a review from Copilot April 2, 2025 05:41

This comment was marked as outdated.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a text encoding/decoding issue in provider-specific badge labels while upgrading several dependencies for improved compatibility.

  • Bumps dependency versions in Cargo.toml files, including worker, insta, once_cell, and regex.
  • Updates the wrangler configuration to use a newer workers version.
  • Simplifies query parameter parsing in Badge.ts by replacing custom logic with Object.fromEntries.

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
deny.toml Added an unmaintained configuration directive
badgers/Cargo.toml Upgraded the insta dependency version
badgers-worker/wrangler.toml Updated the WORKERS_RS_VERSION to the new release
badgers-worker/Cargo.toml Upgraded the worker dependency version
badgers-web/src/utils/Badge.ts Replaced custom query parameter parsing with Object.fromEntries
badgers-utils/Cargo.toml Upgraded once_cell and regex dependency versions
Files not reviewed (1)
  • badgers-worker/package.json: Language not supported
Comments suppressed due to low confidence (1)

badgers-web/src/utils/Badge.ts:44

  • Be aware that Object.fromEntries will only capture the last value for duplicate query parameter keys. If duplicate keys might exist, consider an approach that preserves all values.
const userQueryOverrides = Object.fromEntries(request.nextUrl.searchParams)

@SplittyDev SplittyDev merged commit 079cd7d into main Apr 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unable to put empty spaces when using Codeberg stars + query label

2 participants