Re-apply PR #293 (Developer's guide)#296
Conversation
There was a problem hiding this comment.
💡 Codex Review
This page embeds typical_custom_option.jpg, but the commit deletes the image from the old location and does not add it under the new user/05-custom-validation/ directory, so the rendered page shows a broken image instead of the workflow diagram.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - [Using `ValidatorRegistry`](validator-registry.md) | ||
| - [Custom validation](../05-custom-validation/) | ||
| - [Architecture](../09-developers-guide/architecture.md) | ||
| - [Developer's guide](../06-developers-guide/) |
There was a problem hiding this comment.
Update stale developer guide links
The docs restructure moved the guide under docs/content/docs/validation/developer/**, but this page still links to ../06-developers-guide/, which now resolves to a non-existent path (user/06-developers-guide) and produces a dead “Developer's guide” link for readers; the same broken target is repeated in user/04-validators/implement-a-validator.md and user/05-custom-validation/pass-to-compiler.md.
Useful? React with 👍 / 👎.
98eecbb to
1132eec
Compare
# Conflicts: # dependencies.md # docs/content/docs/validation/user/01-getting-started/adding-to-build.md # pom.xml # version.gradle.kts
armiol
left a comment
There was a problem hiding this comment.
@alexander-yevsyukov LGTM.
| - [Using `ValidatorRegistry`](validator-registry.md) | ||
| - [Custom validation](../05-custom-validation/) | ||
| - [Architecture](../09-developers-guide/architecture.md) | ||
| - [Developer's guide](../06-developers-guide/) |
There was a problem hiding this comment.
Pull request overview
This PR re-applies the documentation-focused changes from #293, restructuring the Validation docs into separate User and Developer guides, updating the docs toolchain configuration, and bumping related build/tooling versions.
Changes:
- Restructured Hugo docs navigation into top-level “Validation user guide” and “Validation developer guide”, adding many new/updated guide pages and removing the old
09-developers-guidesection. - Updated docs tooling/config (Go module metadata for docs,
embed-code.ymlpaths/includes, site-commons module versions). - Bumped project/snapshot versions and updated the Gradle wrapper distribution.
Reviewed changes
Copilot reviewed 43 out of 72 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| version.gradle.kts | Bumps Validation version and updates description comment. |
| tests/validator/build.gradle.kts | Updates comment wording for KSP output usage. |
| README.md | Simplifies README structure; adds reference-style links and redirects “custom validation” to docs. |
| pom.xml | Bumps project version and related dependency versions. |
| java-bundle/build.gradle.kts | Updates copyright year and Apache license URL. |
| gradlew.bat | Updates Windows wrapper script behavior (contains an exit-flow bug; see comments). |
| gradlew | Updates link to Gradle template source revision. |
| gradle/wrapper/gradle-wrapper.properties | Updates Gradle distribution URL and adds retry-related properties. |
| gradle-plugin/src/main/kotlin/io/spine/tools/validation/gradle/ValidationSdk.kt | Renames internal constant and updates artifact name interpolation. |
| docs/go.sum | Adds Go sums for docs module dependencies. |
| docs/go.mod | Adds indirect dependency on site-commons. |
| docs/data/docs/validation/2-0-0-snapshot/sidenav.yml | Splits sidenav into user/developer top-level sections with updated paths. |
| docs/content/docs/validation/user/05-custom-validation/summary.md | Updates links to point at the new developer docs locations. |
| docs/content/docs/validation/user/05-custom-validation/register-the-option.md | Adds new documentation page. |
| docs/content/docs/validation/user/05-custom-validation/pass-to-compiler.md | Updates content; “What’s next” link target currently wrong. |
| docs/content/docs/validation/user/05-custom-validation/implement-the-view.md | Adds new documentation page. |
| docs/content/docs/validation/user/05-custom-validation/implement-the-reaction.md | Adds new documentation page. |
| docs/content/docs/validation/user/05-custom-validation/implement-the-generator.md | Adds new documentation page. |
| docs/content/docs/validation/user/05-custom-validation/declare-the-option.md | Adds new documentation page. |
| docs/content/docs/validation/user/05-custom-validation/declare-event-and-view.md | Adds new documentation page. |
| docs/content/docs/validation/user/05-custom-validation/_index.md | Adds new section index (contains a duplicated nav entry; see comments). |
| docs/content/docs/validation/user/04-validators/validator-registry.md | Adds new documentation page. |
| docs/content/docs/validation/user/04-validators/implement-a-validator.md | Adds/updates content; “What’s next” link target currently wrong. |
| docs/content/docs/validation/user/04-validators/_index.md | Updates formatting and developer guide link. |
| docs/content/docs/validation/user/03-built-in-options/repeated-and-map-fields.md | Adds new documentation page. |
| docs/content/docs/validation/user/03-built-in-options/oneof-fields.md | Minor capitalization fix in link text. |
| docs/content/docs/validation/user/03-built-in-options/message-level-options.md | Adds new documentation page. |
| docs/content/docs/validation/user/03-built-in-options/field-level-options.md | Adds new documentation page. |
| docs/content/docs/validation/user/03-built-in-options/_index.md | Refactors “source of truth” section (includes a whitespace-only line; see comments). |
| docs/content/docs/validation/user/02-concepts/options-overview.md | Adds new documentation page. |
| docs/content/docs/validation/user/02-concepts/error-messages.md | Adds new documentation page. |
| docs/content/docs/validation/user/02-concepts/_index.md | Adds new documentation page. |
| docs/content/docs/validation/user/01-getting-started/generated-code.md | Adds new documentation page. |
| docs/content/docs/validation/user/01-getting-started/first-model.md | Adds new documentation page. |
| docs/content/docs/validation/user/01-getting-started/build-project.md | Adds new documentation page (frontmatter title inconsistency; see comments). |
| docs/content/docs/validation/user/01-getting-started/adding-to-build.md | Updates plugin version in docs snippet. |
| docs/content/docs/validation/user/01-getting-started/_index.md | Adds new documentation page. |
| docs/content/docs/validation/user/00-intro/target-audience.md | Adds new documentation page. |
| docs/content/docs/validation/user/00-intro/philosophy.md | Adds new documentation page. |
| docs/content/docs/validation/user/00-intro/_index.md | Updates terminology and expands introductory content. |
| docs/content/docs/validation/developer/validation-model.md | Adds developer guide page. |
| docs/content/docs/validation/developer/testing-strategy.md | Adds developer guide page. |
| docs/content/docs/validation/developer/runtime-library.md | Adds developer guide page. |
| docs/content/docs/validation/developer/overview-and-audience.md | Adds developer guide page. |
| docs/content/docs/validation/developer/key-modules.md | Adds developer guide page. |
| docs/content/docs/validation/developer/java-code-generation.md | Adds developer guide page. |
| docs/content/docs/validation/developer/extension-points.md | Adds developer guide page. |
| docs/content/docs/validation/developer/build-and-release.md | Adds developer guide page. |
| docs/content/docs/validation/developer/architecture.md | Adds developer guide page. |
| docs/content/docs/validation/developer/adding-a-built-in-option.md | Adds developer guide page. |
| docs/content/docs/validation/09-developers-guide/key-modules.md | Removes legacy developer guide page. |
| docs/content/docs/validation/09-developers-guide/architecture.md | Removes legacy developer guide page. |
| docs/content/docs/validation/09-developers-guide/_index.md | Removes legacy developer guide index. |
| docs/content/docs/validation/_index.md | Updates landing page links to new user/developer guide structure. |
| docs/_settings/embed-code.yml | Adds root/java/context code paths and include filters for embedding. |
| docs/_preview/go.sum | Updates preview module sums for updated Hugo/site-commons deps. |
| docs/_preview/go.mod | Updates preview module requires for updated Hugo/site-commons deps. |
| docs/_preview/content/_index.md | Fixes preview link to point at the new docs root. |
| dependencies.md | Regenerates dependency report for new snapshot version. |
| context/src/main/kotlin/io/spine/tools/validation/ValidationPlugin.kt | Adds trailing comment to closing paren. |
| context/src/main/kotlin/io/spine/tools/validation/ErrorPlaceholder.kt | Fixes grammar in KDoc about runtime duplication. |
| CLAUDE.md | Fixes path to .agents/_TOC.md. |
| buildSrc/src/main/kotlin/io/spine/dependency/local/Validation.kt | Bumps local Validation dependency version. |
| buildSrc/src/main/kotlin/fat-jar.gradle.kts | Updates copyright year/URL and removes an exclusion block. |
| .gitignore | Ignores /.claude/worktrees/. |
| .agents/skills/writer/SKILL.md | Adds guideline about typographic quotes usage for doc references. |
Comments suppressed due to low confidence (3)
docs/content/docs/validation/user/05-custom-validation/pass-to-compiler.md:76
- This link points to
../06-developers-guide/, but the developer docs were moved undervalidation/developer/(seedocs/content/docs/validation/developer/*andsidenav.ymlentries). Update the link target to the new Developer’s Guide location (e.g.../../developer/or a concrete page like../../developer/overview-and-audience.md).
docs/content/docs/validation/user/04-validators/implement-a-validator.md:140 - This link points to
../06-developers-guide/, but the developer docs are now undervalidation/developer/(seedocs/content/docs/validation/developer/*andsidenav.yml). Update the link target to the new Developer’s Guide location (e.g.../../developer/or../../developer/overview-and-audience.md).
docs/content/docs/validation/user/03-built-in-options/_index.md:48 - There is a whitespace-only line here. Please remove it to avoid trailing-whitespace noise in diffs and potential markdown lint issues.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 44 out of 73 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (3)
docs/content/docs/validation/user/05-custom-validation/pass-to-compiler.md:76
- The "What's next" link points to
../06-developers-guide/, but the Developer guide content is now underdocs/content/docs/validation/developer/(e.g.../../developer/or../../developer/overview-and-audience.mdfrom this page). Update this link so it resolves to the new Developer guide location.
docs/content/docs/validation/user/04-validators/implement-a-validator.md:141 - The "What's next" section links to
../06-developers-guide/, but the Developer guide was moved underdocs/content/docs/validation/developer/. Please update this link to the new path (e.g.../../developer/or a specific page under it) so navigation doesn't 404.
docs/content/docs/validation/user/03-built-in-options/_index.md:48 - Line contains a large run of trailing whitespace before the reference link definitions. This tends to create noisy diffs and can trip markdown linters; please remove the stray whitespace-only line.
| echo. 1>&2 | ||
| echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. 1>&2 | ||
| echo. 1>&2 | ||
| echo Please set the JAVA_HOME variable in your environment to match the 1>&2 | ||
| echo location of your Java installation. 1>&2 | ||
|
|
||
| goto fail | ||
| "%COMSPEC%" /c exit 1 | ||
|
|
| echo. 1>&2 | ||
| echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME% 1>&2 | ||
| echo. 1>&2 | ||
| echo Please set the JAVA_HOME variable in your environment to match the 1>&2 | ||
| echo location of your Java installation. 1>&2 | ||
|
|
||
| goto fail | ||
| "%COMSPEC%" /c exit 1 | ||
|
|
Re-applies the changes from #293 (`Developer's guide`), which was accidentally merged because of a misconfiguration of branch protection rules and is being reverted in #295.
The tree state of this branch is identical to the state of `master` before the revert, i.e. it preserves the exact contents that were on `master` after the original PR #293 merge.
Base branch
The base of this PR is set to `revert-pr-293` so that the diff cleanly shows the re-applied changes. Once #295 is merged, switch the base of this PR to `master`.
Original PR description
Test plan