Use VIEW alias for an entity kind#194
Merged
alexander-yevsyukov merged 4 commits intomasterfrom May 4, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the validation model metadata so WhenField is declared with the VIEW entity-kind alias instead of PROJECTION, and also refreshes release metadata/versioned generated files. In the broader codebase, this affects how the (when) validation option’s view model is described in the proto schema used by the validation toolchain.
Changes:
- Switched
WhenFieldinviews.protofromPROJECTIONto theVIEWalias for(entity).kind. - Bumped the project snapshot version from
2.0.0-SNAPSHOT.239to.240. - Renamed the Windows CI job display name and refreshed the generated dependency report.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
version.gradle.kts |
Updates publish version to the new snapshot. |
validation/src/main/proto/spine/tools/time/validation/views.proto |
Changes WhenField entity-kind metadata from PROJECTION to VIEW. |
pom.xml |
Updates Maven project version to match the new snapshot. |
dependencies.md |
Refreshes generated dependency report headers/timestamps for the new version. |
.github/workflows/build-on-windows.yml |
Renames the Windows CI job label. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // A view of a field that is marked with `(when)` option. | ||
| message WhenField { | ||
| option (entity).kind = PROJECTION; | ||
| option (entity).kind = VIEW; |
| build: | ||
| runs-on: windows-latest | ||
| name: Build and test on Windows | ||
| name: Build on Windows |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #194 +/- ##
=========================================
Coverage 83.88% 83.88%
Complexity 304 304
=========================================
Files 60 60
Lines 1086 1086
Branches 46 46
=========================================
Hits 911 911
Misses 165 165
Partials 10 10 🚀 New features to boost your workflow:
|
armiol
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
WhenFieldproto type so that it usesVIEWalias for the(entity).kind. It would read simpler in the Validation documentation.Also, the PR shortens the GitHub workflow when building on Windows.