Issue-625: allow injecting a custom HttpClient into the Ds3Client without relying solely on the internal builder logic.#627
Open
RachelTucker wants to merge 1 commit into
Open
Issue-625: allow injecting a custom HttpClient into the Ds3Client without relying solely on the internal builder logic.#627RachelTucker wants to merge 1 commit into
RachelTucker wants to merge 1 commit into
Conversation
Contributor
RachelTucker
commented
May 8, 2026
RachelTucker
commented
- Changed the access modifier of the NetworkClientImpl constructor that accepts a CloseableHttpClient from private to public, enabling external injection of custom-configured HTTP clients.
- Added a withNetworkClient(NetworkClient) method to Ds3ClientBuilder to allow users to provide a pre-configured NetworkClient (potentially wrapping a custom HttpClient) through the builder interface.
- Updated the Ds3ClientBuilder.build() method to prioritize the provided networkClient if it has been set.
- Resolved issue #625 to allow injecting a custom HttpClient into the Ds3Client without relying solely on the internal builder logic. ### Changes - Changed the access modifier of the NetworkClientImpl constructor that accepts a CloseableHttpClient from private to public, enabling external injection of custom-configured HTTP clients. - Added a withNetworkClient(NetworkClient) method to Ds3ClientBuilder to allow users to provide a pre-configured NetworkClient (potentially wrapping a custom HttpClient) through the builder interface. - Updated the Ds3ClientBuilder.build() method to prioritize the provided networkClient if it has been set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.