Feature: Add support for authenticating the Jamf collector with API client#7
Open
d3vzer0 wants to merge 12 commits into
Open
Feature: Add support for authenticating the Jamf collector with API client#7d3vzer0 wants to merge 12 commits into
d3vzer0 wants to merge 12 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new authentication layer for the Jamf collector so it can authenticate either via username/password or via OAuth client credentials, and wires that into the DLT REST client used by the collector.
Changes:
- Introduces
JamfPasswordCredentialsandJamfClientCredentialsplus aJamfAuthrequest auth handler. - Updates the Jamf DLT
source()signature to take a singlecredentialsobject and uses it to configure the REST client (base URL + auth).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/openhound_jamf/source.py |
Switches the DLT source to accept unified credentials and uses JamfAuth for request authentication. |
src/openhound_jamf/auth.py |
Adds credential models for password/client auth and implements token acquisition + request header injection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two auth methods for the Jamf collector:
This does introduce a breaking change. Previously the credentials were configured as follows:
This update requires the config (secrets.toml) to be set as:
Based on: #6