Conversation
mistahj67
added
the
api
Contributor
📝 WalkthroughWalkthroughAdds an "alerts" feature flag: a Goose migration inserts an idempotent ChangesAdd alerts feature flag
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
urangel
reviewed
May 28, 2026
urangel
approved these changes
May 28, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
cmd/api/src/model/appcfg/flag.go (1)
110-116: ⚡ Quick winHoist and group local variable initialization in
GetFlagEnabled.Please align this function with the Go guideline by declaring locals at the top via a
var (...)block.Proposed diff
func GetFlagEnabled(ctx context.Context, service GetFlagByKeyer, key string) bool { - if flag, err := service.GetFlagByKey(ctx, key); err != nil { + var ( + flag FeatureFlag + err error + ) + + if flag, err = service.GetFlagByKey(ctx, key); err != nil { slog.WarnContext(ctx, "Failed to fetch feature flag; returning false", slog.String("key", key)) return false - } else { - return flag.Enabled } + + return flag.Enabled }As per coding guidelines: "Group variable initializations in a
var ( ... )block and hoist them to the top of the function when possible".🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@cmd/api/src/model/appcfg/flag.go` around lines 110 - 116, Hoist and group the local variables used in GetFlagEnabled by declaring them in a var (...) block at the top of the function (e.g., var flag *FlagType, err error) then call service.GetFlagByKey(ctx, key) to assign those variables, check err and call slog.WarnContext("Failed to fetch feature flag; returning false", slog.String("key", key)) when err != nil, otherwise return flag.Enabled; keep references to GetFlagEnabled, service.GetFlagByKey, flag, err and slog.WarnContext when applying the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@cmd/api/src/model/appcfg/flag.go`:
- Around line 110-116: Hoist and group the local variables used in
GetFlagEnabled by declaring them in a var (...) block at the top of the function
(e.g., var flag *FlagType, err error) then call service.GetFlagByKey(ctx, key)
to assign those variables, check err and call slog.WarnContext("Failed to fetch
feature flag; returning false", slog.String("key", key)) when err != nil,
otherwise return flag.Enabled; keep references to GetFlagEnabled,
service.GetFlagByKey, flag, err and slog.WarnContext when applying the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 4b58b569-406a-4f35-961d-590df4f9c583
📒 Files selected for processing (2)
cmd/api/src/database/migration/migrations/20260527000000_v9_add_alerts_feature_flag.sqlcmd/api/src/model/appcfg/flag.go
🚧 Files skipped from review as they are similar to previous changes (1)
- cmd/api/src/database/migration/migrations/20260527000000_v9_add_alerts_feature_flag.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds feature flag for Alerts
Describe your changes in detail
Motivation and Context
Resolves BED-8382
Why is this change required? What problem does it solve?
How Has This Been Tested?
Verified migration ran and new record was created on FF table
Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.
Screenshots (optional):
Types of changes
Checklist:
Summary by CodeRabbit
New Features
Refactor