Skip to content

fix(config): change default admin email - BED-8189#2830

Open
cami-specter wants to merge 2 commits into
mainfrom
wip-BED-8189-modify-admin-email
Open

fix(config): change default admin email - BED-8189#2830
cami-specter wants to merge 2 commits into
mainfrom
wip-BED-8189-modify-admin-email

Conversation

@cami-specter
Copy link
Copy Markdown
Contributor

@cami-specter cami-specter commented May 27, 2026

Description

Changes the default admin email address in BHCE from spam@example.com to admin@example.com.

  • updates hardcoded default in NewDefaultAdminConfiguration
  • updates example docker-compose config
  • updates local-harnesses template
  • updates helm template
  • BHE changes to local-harnesses/helm templates. PR:

Note

The docs repo also has one reference to spam@example.com. Will mention this to update it at deployment time.

Motivation and Context

A different default admin email (shown to users on first setup) was requested in BED-8189

How Has This Been Tested?

  • Ran pfc
  • Ran integration tests for BHCE (known flaky test failures)
  • Ran unit tests
  • There are no other references to spam@example.com except for ui tests that just use it as a testcase.

See note above for reference in bloodhound-docs

Screenshots (optional):

Types of changes

  • Chore (a change that does not modify the application functionality)

Checklist:

Summary by CodeRabbit

  • Chores
    • Updated the default admin email address across configuration files from spam@example.com to admin@example.com.

Review Change Stack

…n@example.com

- updates hardcoded default in NewDefaultAdminConfiguration
- updates example docker-compose config
- updates local-harnesses and helm templates

fixes: BED-8189
@cami-specter cami-specter self-assigned this May 27, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 304a5c09-d186-48c1-badb-af6098bd5350

📥 Commits

Reviewing files that changed from the base of the PR and between d12ebff and 778a0d9.

📒 Files selected for processing (4)
  • cmd/api/src/config/default.go
  • examples/docker-compose/bloodhound.config.json
  • examples/helm/templates/cmbh.yaml
  • local-harnesses/build.config.json.template

📝 Walkthrough

Walkthrough

The default admin account email address is updated from spam@example.com to admin@example.com across four configuration and code locations: the API configuration code, Docker Compose example, Helm chart template, and local development harness.

Changes

Default Admin Email Update

Layer / File(s) Summary
Default admin email address update
cmd/api/src/config/default.go, examples/docker-compose/bloodhound.config.json, examples/helm/templates/cmbh.yaml, local-harnesses/build.config.json.template
The default admin email address is changed from spam@example.com to admin@example.com in the API configuration code, Docker Compose example configuration, Helm chart template, and local development harness template.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: updating the default admin email address, with a specific ticket reference.
Description check ✅ Passed The description covers all required sections including motivation, testing details, and change type, with proper checklist completion.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch wip-BED-8189-modify-admin-email

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cami-specter
Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

✅ Actions performed

Full review triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant