Skip to content

feat(config): JIT Teleport Configuration BED-8326#2818

Open
mvlipka wants to merge 4 commits into
mainfrom
BED-8326/JIT-Teleport-Integration
Open

feat(config): JIT Teleport Configuration BED-8326#2818
mvlipka wants to merge 4 commits into
mainfrom
BED-8326/JIT-Teleport-Integration

Conversation

@mvlipka
Copy link
Copy Markdown
Contributor

@mvlipka mvlipka commented May 26, 2026

Description

This simply adds new configurations in order to run Teleport locally

Motivation and Context

Resolves: BED-8326

Why is this change required? What problem does it solve?

How Has This Been Tested?

See BHE equivalent PR for testing details

Screenshots (optional):

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

Summary by CodeRabbit

  • New Features
    • Added Teleport integration configuration support, enabling customization of connection settings.
    • Default Teleport parameters are now pre-configured for seamless connectivity out of the box.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

📝 Walkthrough

Walkthrough

This PR adds Teleport integration support to the API configuration system. A new TeleportConfiguration struct is introduced with DialAddress and WebAddress fields, integrated into the main Configuration struct, and initialized with default connection addresses in the default configuration factory.

Changes

Teleport Configuration Support

Layer / File(s) Summary
Teleport configuration types and defaults
cmd/api/src/config/config.go, cmd/api/src/config/default.go
New TeleportConfiguration struct with dial_address and web_address fields is defined and added to the main Configuration struct under the teleport JSON key. Default configuration initializes Teleport with DialAddress set to teleport:3080 and WebAddress set to localhost:3080.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely incomplete with critical sections missing or only partially filled out. Provide detailed motivation for why Teleport configuration is needed, clarify which equivalent PR to reference for testing details, and add/update GoDocs comments for new TeleportConfiguration struct fields.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly references the primary change (Teleport Configuration) and includes the associated ticket number (BED-8326), making it specific and directly related to the changeset.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch BED-8326/JIT-Teleport-Integration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mvlipka mvlipka changed the title Bed 8326/jit teleport integration feat(config): JIT Teleport Configuration BED-8326 May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant