Skip to content

feat: ingest logic to use FileService - BED-8317,BED-8318#2808

Draft
mykeelium wants to merge 4 commits into
mcuomo/BED-8316from
mcuomo/BED-8317
Draft

feat: ingest logic to use FileService - BED-8317,BED-8318#2808
mykeelium wants to merge 4 commits into
mcuomo/BED-8316from
mcuomo/BED-8317

Conversation

@mykeelium
Copy link
Copy Markdown
Contributor

@mykeelium mykeelium commented May 21, 2026

Description

This change migrates the ingestion logic to use the new FileService. In addition, the cleanup daemon was updated to be able to delete files using the new FileService.

Motivation and Context

Resolves BED-8317,BED-8318

How Has This Been Tested?

The application was started and multiple ingested files were created. The data from these files were ingested correctly. In addition new tests were added.

For the cleanup, files were added to the directories, and both with exemptions and without PruneData was run to ensure the proper files were deleted.

Screenshots (optional):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • New feature (non-breaking change which adds functionality)

Checklist:

@mykeelium mykeelium self-assigned this May 21, 2026
@mykeelium mykeelium added enhancement New feature or request api A pull request containing changes affecting the API code. labels May 21, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b5ee1b4e-e000-4674-94c7-33cef970ce67

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mcuomo/BED-8317

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mykeelium mykeelium changed the title feat: ingest logic to use FileService - BED-8317 feat: ingest logic to use FileService - BED-8317,BED-8318 May 21, 2026
}
defer sourceFile.Close()

scratchFile, err = os.CreateTemp(scratchDirectory, "archive-*")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little confused why we're doing direct OS file operations here, doesn't file service have a local storage driver?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, but this is supposed to be a stage earlier than the fileService, in this case spooling is done to take the users file and validate it prior to saving it to the file service. In the event that we have a file service that is not on the os, this handles the resources ensuring they are available for the fileService. Not in this scope, but maybe the upload could be shifted to a presigned url so we do not need this step at all.

Comment thread cmd/api/src/services/upload/upload.go Outdated
Comment thread cmd/api/src/services/upload/upload.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api A pull request containing changes affecting the API code. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants