Skip to content

fix triangular solve test #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yhmtsai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix triangular solve test #57

yhmtsai wants to merge 1 commit into from

Conversation

@yhmtsai
Copy link
Contributor

@yhmtsai yhmtsai commented Aug 21, 2025

Summary:
This fixes the triangular solve test, which worked on rhs = 0 and does not handle the lower_triangular cases in reference.

Details:

set the right hand side to 1 now, and ensure the if condition.
Also, call the right parameter to fit the test name

Merge Checklist:

  • Passing CI
  • Update documentation or README.md
  • Additional Test/example added (if applicable) and passing
  • At least one reviewer approval
  • (optional) Clang sanitizer scan run and triaged
  • Clang formatter applied (verified as part of passing CI)

@yhmtsai yhmtsai self-assigned this Aug 21, 2025
@yhmtsai yhmtsai mentioned this pull request Aug 21, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@yhmtsai yhmtsai

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yhmtsai