Skip to content

Fix TypeError in ported_string when input is email.header.Header #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndreasLF wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix TypeError in ported_string when input is email.header.Header #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/mailparser/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@ def ported_string(raw_data, encoding="utf-8", errors="ignore"):
if not raw_data:
return str()

if isinstance(raw_data, email.header.Header):
return str(raw_data)

if isinstance(raw_data, str):
return raw_data

Expand Down
12 changes: 12 additions & 0 deletions tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,3 +586,15 @@ def test_receiveds_format_delay_no_previous_date(self):
self.assertEqual(result[1]["delay"], 0)
# But should have a valid date itself
self.assertIsNotNone(result[1].get("date_utc"))

def test_ported_string_handles_header_object(self):
"""
Test that ported_string can accept an email.header.Header object
and return a decoded string without crashing.
"""
from email.header import Header
raw_val = 'attachment;\r\nfilename="Just a text – 2026.pdf'
header_obj = Header(raw_val, charset="utf-8")
result = ported_string(header_obj)
self.assertIsInstance(result, str)
self.assertEqual(result, raw_val)
Loading