Skip to content

Fix handling of self-signed certs in s3_conn #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chess-knight wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix handling of self-signed certs in s3_conn #1141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions Tests/iaas/scs_0123_mandatory_services/mandatory_services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,13 @@ def compute_scs_0123_service_presence(services_lookup, *names):

def s3_conn(creds, conn):
"""Return an s3 client conn"""
insecure = conn.config.config.get("insecure")
verify = conn.config.config.get("verify")
cacert = conn.config.config.get("cacert")
# TODO: Handle self-signed certs (from ca_cert in openstack config)
if cacert:
logger.warning(f"Trust all Certificates in S3, OpenStack uses {cacert}")
vrfy = False if (insecure is True or verify is False) else \
(cacert or (verify if isinstance(verify, str) else None))
return boto3.resource(
's3', endpoint_url=creds["HOST"], verify=not cacert,
's3', endpoint_url=creds["HOST"], verify=vrfy,
aws_access_key_id=creds["AK"], aws_secret_access_key=creds["SK"],
)

Expand Down
Loading