[filesystem] optimize file search by splitting it into two passes #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass 1. We first go thru all search paths and try to open it using CWin32ReadOnlyFile. In most cases the file can be opened using it, so we can skip CStdioFile in this pass which should be a good speedup. Pass 2. We failed to open it using CWin32ReadOnlyFile, now were going thru everything again but this time were going to use CStdioFile. If it now fails, the file doesn't exist.
dimhotepus
force-pushed
the
master
branch
2 times, most recently
from
41bd79f to
9544370
Compare
dimhotepus
force-pushed
the
master
branch
11 times, most recently
from
3fd9d80 to
dbb5131
Compare
dimhotepus
force-pushed
the
master
branch
2 times, most recently
from
1d814a3 to
e099636
Compare
9 tasks
dimhotepus
force-pushed
the
master
branch
9 times, most recently
from
d14eed2 to
c3ffcfe
Compare
dimhotepus
force-pushed
the
master
branch
4 times, most recently
from
2a20613 to
b8ee27e
Compare
32 tasks
dimhotepus
force-pushed
the
master
branch
5 times, most recently
from
739a853 to
a997975
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes the file seach by splitting the CWin32ReadOnlyFile and CStdioFile into seperate passes.
when it searches for a file, it tries to open the file in every single searchpath and trying both(when in
rb) seems pointless.in most cases CWin32ReadOnlyFile should return the valid handle for
rbsearches.This should be ~50% speed up for files that aren't in the first search path like
platform_misc_000.vpkNote
Since I currently can't build the master branch I couldn't check and test it in the lastest version but it should work.