tests: add istanbul coverage for tests#2470
Open
jankapunkt wants to merge 1 commit intoSortableJS:masterfrom
Open
tests: add istanbul coverage for tests#2470jankapunkt wants to merge 1 commit intoSortableJS:masterfrom
jankapunkt wants to merge 1 commit intoSortableJS:masterfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

As mentioned in discussion #2458 further improvement on this library is stalled as there are not enough automated tests to prevent regressions when reviewing PRs.
A foundation to improve on tests is to run tests with code coverage collected in order to detect yet untested parts of the code and improve the overall test quantity (yes, coverage is not a quality indicator...)
You can run the tests with coverage by
npm run test:coverage. Once the tests are done, the coverage is a) printed to the terminal and b) saved in various formats in the (git-ignored)coveragefolder.No current tests were rewritten or changed.
An initial run on my local machine: